Skip to content

Adopt the Coherent system - #47

Merged
jaraco merged 20 commits into
mainfrom
experiment/coherent
May 16, 2026
Merged

jaraco merged 20 commits into
mainfrom
experiment/coherent

Conversation

@jaraco

@jaraco jaraco commented May 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

@jaraco

jaraco commented May 8, 2026

Copy link
Copy Markdown
Owner Author

The tests are failing upstream, but pass fine for me locally. With e5e418b, tests pass in CI but fail locally. My guess is CI has a stale ruff.

@jaraco

jaraco commented May 8, 2026

Copy link
Copy Markdown
Owner Author

PyPy is failing with an indication that PyPy 3.10 may not be supported.

creating virtual environment...
installing coherent-test from spec 'coherent-test>=0.7.0'...
Fatal error from pip prevented installation. Full pip output in file:
    /opt/pipx/logs/cmd_2026-05-08_18.15.34_pip_errors.log

pip failed to build package:
    cryptography

Some possibly relevant errors from pip install:
        error: failed to run custom build command for `pyo3-ffi v0.28.3`
          error: the configured PyPy interpreter version (3.10) is lower than PyO3's minimum supported version (3.11)
        Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/opt/pipx/.cache/3a066269010a8cb/bin/python', '--compatibility', 'off'] returned non-zero exit status 1
Error installing coherent-test from spec 'coherent-test>=0.7.0'.

@jaraco

jaraco commented May 15, 2026

Copy link
Copy Markdown
Owner Author

The tests are failing upstream, but pass fine for me locally. With e5e418b, tests pass in CI but fail locally. My guess is CI has a stale ruff.

I made an update to coherent.test so it now emits the packages installed, but I've found that the CI run and my local run both have the same ruff version (0.15.13), so the difference is not due to the version of ruff installed in the environment. Perhaps the issue is more nuanced - like maybe pytest-ruff isn't using the version of ruff installed in the environment. Or maybe it has nothing to do with the ruff version.

First, I need to confirm this disparity only affects the coherent build.

@jaraco

jaraco commented May 16, 2026

Copy link
Copy Markdown
Owner Author

The tests are failing upstream, but pass fine for me locally. With e5e418b, tests pass in CI but fail locally. My guess is CI has a stale ruff.

I made an update to coherent.test so it now emits the packages installed, but I've found that the CI run and my local run both have the same ruff version (0.15.13), so the difference is not due to the version of ruff installed in the environment. Perhaps the issue is more nuanced - like maybe pytest-ruff isn't using the version of ruff installed in the environment. Or maybe it has nothing to do with the ruff version.

First, I need to confirm this disparity only affects the coherent build.

I figured out the issue. On my local system, I'd previously checked out the project as a non-coherent project and run ruff there. When that happened, populated the ruff cache with "tempora" as a first-party import. When switching to coherent, ruff no longer detects "tempora" as a first party import, so demands a different syntax. So just a git clean -fdx makes the behavior consistent with CI. I do need to report the issue with first party detection upstream, however.

@jaraco
jaraco merged commit b6058cc into main May 16, 2026
63 of 70 checks passed
@jaraco
jaraco deleted the experiment/coherent branch May 16, 2026 21:57
@jaraco

jaraco commented May 18, 2026

Copy link
Copy Markdown
Owner Author

Note that 0a1eabf needed to be added to remove the AGENTS.md unintentionally left in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants