Skip to content

overhaul the LESStep demo and rename it to BackwardFacingStep #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muezabdalla wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

overhaul the LESStep demo and rename it to BackwardFacingStep #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0aedb53
remake the LESStep macros and rename it to BackwardFacingStep
muezabdalla Jul 1, 2026
90e8995
update the testfiles for the BackwardFacingStep demo
muezabdalla Jul 1, 2026
a77377f
add the brep file and createPatch file for the testfile in BackwardFa…
muezabdalla Jul 1, 2026
8b5cab7
add initialization for the U and P
muezabdalla Jul 15, 2026
4b3e59c
use UseOutletPValue to avoid error in running the macro and to fix th…
muezabdalla Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions Data/TestFiles/cases/LESStep/case/0/U → ...stFiles/cases/BackwardFacingStep/case/0/U
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,6 @@ internalField uniform (0.0 0.0 0.0);
boundaryField
{

constraint
{
type symmetry;
value $internalField;
}

wall
{
type symmetry;
value $internalField;
}

wall001
{
// movingWallVelocity reduces to fixedValue if the mesh is not moving
type movingWallVelocity;
value uniform (0 0 0);
}

inlet
{
// Fix all three components of velocity on inflow and only the normal component on outflow,
Expand All @@ -59,6 +40,25 @@ boundaryField
value $internalField;
}

constraint
{
type symmetry;
value $internalField;
}

constraint001
{
type symmetry;
value $internalField;
}

wall
{
// movingWallVelocity reduces to fixedValue if the mesh is not moving
type movingWallVelocity;
value uniform (0 0 0);
}

defaultFaces
{
type slip;
Expand Down
26 changes: 13 additions & 13 deletions Data/TestFiles/cases/LESStep/case/0/k → ...stFiles/cases/BackwardFacingStep/case/0/k
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,34 +20,34 @@ internalField uniform 0.0;
boundaryField
{

constraint
inlet
{
type symmetry;
value $internalField;
type fixedValue;
value uniform 0.15;
}

wall
outlet
{
type symmetry;
type inletOutlet;
inletValue $internalField;
value $internalField;
}

wall001
constraint
{
type kqRWallFunction;
type symmetry;
value $internalField;
}

inlet
constraint001
{
type fixedValue;
value uniform 0.15;
type symmetry;
value $internalField;
}

outlet
wall
{
type inletOutlet;
inletValue $internalField;
type kqRWallFunction;
value $internalField;
}

Expand Down
28 changes: 14 additions & 14 deletions Data/TestFiles/cases/LESStep/case/0/nut → ...Files/cases/BackwardFacingStep/case/0/nut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,34 +20,34 @@ internalField uniform 0.0;
boundaryField
{

constraint
inlet
{
type symmetry;
value $internalField;
type fixedValue;
value uniform 50.0;
}

wall
outlet
{
type symmetry;
type calculated;
value $internalField;
}

wall001
constraint
{
type nutkWallFunction;
value uniform 0;
type symmetry;
value $internalField;
}

inlet
constraint001
{
type fixedValue;
value uniform 50.0;
type symmetry;
value $internalField;
}

outlet
wall
{
type calculated;
value $internalField;
type nutkWallFunction;
value uniform 0;
}

defaultFaces
Expand Down
28 changes: 14 additions & 14 deletions Data/TestFiles/cases/LESStep/case/0/p → ...stFiles/cases/BackwardFacingStep/case/0/p
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,38 +15,38 @@ FoamFile

dimensions [0 2 -2 0 0 0 0];

internalField uniform 0.0;
internalField uniform 83333.33333333334;

@oliveroxtoby oliveroxtoby Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Do the tests pass though? This seems like a strange p value...

@muezabdalla muezabdalla Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for that I did not run the test because I thought this will not affect it and I was in a a hurry. but now I fixed it with the other typos and errors.


boundaryField
{

constraint
inlet
{
type symmetry;
value $internalField;
type zeroGradient;
}

wall
outlet
{
type symmetry;
type totalPressure;
p0 uniform 0.0;
value $internalField;
}

wall001
constraint
{
type zeroGradient;
type symmetry;
value $internalField;
}

inlet
constraint001
{
type zeroGradient;
type symmetry;
value $internalField;
}

outlet
wall
{
type totalPressure;
p0 uniform 0.0;
value $internalField;
type zeroGradient;
}

defaultFaces
Expand Down
2 changes: 1 addition & 1 deletion Data/TestFiles/cases/LESStep/case/Allrun → ...iles/cases/BackwardFacingStep/case/Allrun
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ then
fi

# Copy mesh from mesh case dir if available
MESHDIR="../meshCaseLESStep"
MESHDIR="../meshCaseBackwardFacingStep"
if [ -f "$MESHDIR"/constant/polyMesh/faces ]
then
rm -rf constant/polyMesh
Expand Down
0 Data/TestFiles/cases/LESStep/case/Allrun.bat → .../cases/BackwardFacingStep/case/Allrun.bat
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion Data/TestFiles/cases/LESStep/case/Allrun.ps1 → .../cases/BackwardFacingStep/case/Allrun.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function runParallel([int]$NumProcs, [string]$cmd)
$PSDefaultParameterValues['Out-File:Encoding'] = 'ascii'

# Copy mesh from mesh case dir if available
$MESHDIR = "../meshCaseLESStep"
$MESHDIR = "../meshCaseBackwardFacingStep"
if( Test-Path -PathType Leaf $MESHDIR/constant/polyMesh/faces )
{
rm -ErrorAction SilentlyContinue -Recurse -Force constant/polyMesh
Expand Down
0 ...s/LESStep/case/constant/momentumTransport → ...acingStep/case/constant/momentumTransport
View file
Open in desktop
File renamed without changes.
20 changes: 10 additions & 10 deletions ...s/LESStep/case/constant/polyMesh/boundary → ...acingStep/case/constant/polyMesh/boundary
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,29 @@ FoamFile
// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

(
constraint
inlet
{
type symmetry;
type patch;
}

wall
outlet
{
type symmetry;
type patch;
}

wall001
constraint
{
type wall;
type symmetry;
}

inlet
constraint001
{
type patch;
type symmetry;
}

outlet
wall
{
type patch;
type wall;
}

defaultFaces
Expand Down
0 ...LESStep/case/constant/transportProperties → ...ingStep/case/constant/transportProperties
View file
Open in desktop
File renamed without changes.
0 ...ESStep/case/constant/turbulenceProperties → ...ngStep/case/constant/turbulenceProperties
View file
Open in desktop
File renamed without changes.
0 Data/TestFiles/cases/LESStep/case/pv.foam → ...les/cases/BackwardFacingStep/case/pv.foam
View file
Open in desktop
File renamed without changes.
0 .../TestFiles/cases/LESStep/case/pvScript.py → ...cases/BackwardFacingStep/case/pvScript.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...les/cases/LESStep/case/system/controlDict → ...ackwardFacingStep/case/system/controlDict
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ FoamFile

application pimpleFoam;

startFrom latestTime;
startFrom startTime;

startTime 0;

Expand Down
20 changes: 10 additions & 10 deletions ...cases/LESStep/case/system/createPatchDict → ...ardFacingStep/case/system/createPatchDict
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,46 +19,46 @@ pointSync false;
patches
(
{
name constraint;
name inlet;
patchInfo
{
type symmetry;
type patch;
}
constructFrom patches;
patches ( "patch_1_.*" );
}
{
name wall;
name outlet;
patchInfo
{
type symmetry;
type patch;
}
constructFrom patches;
patches ( "patch_2_.*" );
}
{
name wall001;
name constraint;
patchInfo
{
type wall;
type symmetry;
}
constructFrom patches;
patches ( "patch_3_.*" );
}
{
name inlet;
name constraint001;
patchInfo
{
type patch;
type symmetry;
}
constructFrom patches;
patches ( "patch_4_.*" );
}
{
name outlet;
name wall;
patchInfo
{
type patch;
type wall;
}
constructFrom patches;
patches ( "patch_5_.*" );
Expand Down
0 ...ases/LESStep/case/system/decomposeParDict → ...rdFacingStep/case/system/decomposeParDict
View file
Open in desktop
File renamed without changes.
0 ...Files/cases/LESStep/case/system/fvSchemes → .../BackwardFacingStep/case/system/fvSchemes
View file
Open in desktop
File renamed without changes.
0 ...iles/cases/LESStep/case/system/fvSolution → ...BackwardFacingStep/case/system/fvSolution
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions .../TestFiles/cases/LESStep/meshCase/Allmesh → ...cases/BackwardFacingStep/meshCase/Allmesh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ then
else
NTHREADS=$(nproc)
fi
runCommand "$GMSH_EXE" -nt $NTHREADS - "gmsh/Pad_Geometry.geo"
runCommand "$GMSH_EXE" -nt $NTHREADS - "gmsh/Fusion_Geometry.geo"

# Unset and source bashrc
FOAMDIR="/usr/lib/openfoam/openfoam2512"
Expand All @@ -42,7 +42,7 @@ then
source "$FOAMDIR/etc/bashrc"
fi

runCommand gmshToFoam "gmsh/Pad_Geometry.msh"
runCommand gmshToFoam "gmsh/Fusion_Geometry.msh"

# polyDualMesh doesn't seem to convert cell zones or sets
rm -f constant/polyMesh/cellZones
Expand Down
0 ...tFiles/cases/LESStep/meshCase/Allmesh.bat → ...s/BackwardFacingStep/meshCase/Allmesh.bat
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...tFiles/cases/LESStep/meshCase/Allmesh.ps1 → ...s/BackwardFacingStep/meshCase/Allmesh.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ $ErrorView = 'ConciseView'

$GMSH_EXE = "/home/oliver/software/gmsh-4.13.1-Linux64/bin/gmsh"
$NTHREADS = (Get-CimInstance Win32_ComputerSystem).NumberOfLogicalProcessors
runCommand "$GMSH_EXE" -nt $NTHREADS - "gmsh/Pad_Geometry.geo"
runCommand "$GMSH_EXE" -nt $NTHREADS - "gmsh/Fusion_Geometry.geo"

runCommand gmshToFoam "gmsh/Pad_Geometry.msh"
runCommand gmshToFoam "gmsh/Fusion_Geometry.msh"

# polyDualMesh doesn't seem to convert cell zones
rm -ErrorAction SilentlyContinue constant/polyMesh/cellZones
Expand Down
Loading