Skip to content

fix(browser): resolve out-of-process iframe targets #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzozanee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(browser): resolve out-of-process iframe targets #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions extension/src/background.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,49 @@ describe('background tab isolation', () => {
]);
});

it('includes out-of-process iframe targets that are missing from the frame tree', async () => {
const { chrome } = createChromeMock();
chrome.debugger.getTargets = vi.fn(async () => ([
{ id: 'page-1', tabId: 1, type: 'page', url: 'https://automation.example', title: 'automation' },
{ id: 'oopif-frame', tabId: 1, type: 'other', url: 'https://x.example/widget', title: 'oopif-x' },
]));
chrome.debugger.sendCommand = vi.fn(async (_target: unknown, method: string) => {
if (method === 'Runtime.enable') return {};
if (method === 'Runtime.evaluate') return { result: { value: 1 } };
if (method === 'Page.getFrameTree') {
return {
frameTree: {
frame: { id: 'root', url: 'https://main.example/' },
childFrames: [
{ frame: { id: 'same-origin-parent', url: 'https://main.example/embed' } },
],
},
};
}
return {};
});
vi.stubGlobal('chrome', chrome);

const mod = await import('./background');
mod.__test__.setAutomationWindowId(adapterKey('twitter'), 1);

const result = await mod.__test__.handleCommand({ id: 'frames', action: 'frames', session: 'twitter', surface: 'adapter' });
const execResult = await mod.__test__.handleCommand({
id: 'exec',
action: 'exec',
code: 'document.title',
frameIndex: 0,
session: 'twitter',
surface: 'adapter',
});

expect(result.ok).toBe(true);
expect(result.data).toEqual([
{ index: 0, frameId: 'oopif-frame', url: 'https://x.example/widget', name: 'oopif-x' },
]);
expect(execResult.ok).toBe(true);
});

it('does not parse lease-key separators from command session fields', async () => {
const { chrome } = createChromeMock();
vi.stubGlobal('chrome', chrome);
Expand Down Expand Up @@ -441,6 +484,7 @@ describe('background tab isolation', () => {
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
registerFrameTracking: vi.fn(),
hasActiveNetworkCapture: vi.fn(() => false),
detach: vi.fn(async () => {}),
ensureAttached: vi.fn(async () => {}),
Expand Down Expand Up @@ -486,6 +530,7 @@ describe('background tab isolation', () => {
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
registerFrameTracking: vi.fn(),
hasActiveNetworkCapture: vi.fn(() => false),
detach: vi.fn(async () => {}),
waitForDownload,
Expand Down Expand Up @@ -522,6 +567,7 @@ describe('background tab isolation', () => {
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
registerFrameTracking: vi.fn(),
hasActiveNetworkCapture: vi.fn(() => false),
detach: vi.fn(async () => {}),
evaluateAsync: vi.fn(async () => 'main-result'),
Expand All @@ -548,6 +594,7 @@ describe('background tab isolation', () => {
startNetworkCapture: vi.fn(),
readNetworkCapture: vi.fn(async () => []),
ensureAttached: vi.fn(),
getIframeTargets: vi.fn(async () => []),
}));

const mod = await import('./background');
Expand Down Expand Up @@ -581,6 +628,7 @@ describe('background tab isolation', () => {
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
registerFrameTracking: vi.fn(),
hasActiveNetworkCapture: vi.fn(() => false),
detach: vi.fn(async () => {}),
evaluateAsync,
Expand All @@ -592,6 +640,7 @@ describe('background tab isolation', () => {
startNetworkCapture: vi.fn(),
readNetworkCapture: vi.fn(async () => []),
ensureAttached: vi.fn(),
getIframeTargets: vi.fn(async () => []),
}));

const mod = await import('./background');
Expand Down Expand Up @@ -800,6 +849,7 @@ describe('background tab isolation', () => {
const detachMock = vi.fn(async () => {});
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
hasActiveNetworkCapture: vi.fn(() => true),
detach: detachMock,
}));
Expand Down Expand Up @@ -1029,6 +1079,7 @@ describe('background tab isolation', () => {
let maxInFlight = 0;
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
evaluateAsync: vi.fn(async (tabId: number, code: string) => {
inFlight++;
maxInFlight = Math.max(maxInFlight, inFlight);
Expand Down Expand Up @@ -1067,6 +1118,7 @@ describe('background tab isolation', () => {
let maxInFlight = 0;
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
evaluateAsync: vi.fn(async (tabId: number, code: string) => {
inFlight++;
maxInFlight = Math.max(maxInFlight, inFlight);
Expand Down Expand Up @@ -1985,6 +2037,7 @@ describe('background tab isolation', () => {
vi.doMock('./cdp', () => ({
registerListeners: vi.fn(),
registerFrameTracking: vi.fn(),
registerFrameTracking: vi.fn(),
hasActiveNetworkCapture: vi.fn(() => false),
detach: vi.fn(async () => {}),
}));
Expand Down
Loading