Skip posting vote results when poll data is unreadable#10
Open
its-applekid wants to merge 1 commit into
Open
Conversation
When voteResults is null (poll can't be read from Discord), skip posting results instead of creating and posting misleading all-zero results. This prevents confusing 'failure' messages with 0 voters and 0% participation when the actual issue is that Gary couldn't read the poll data from EasyPoll.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
voteResultsis null (poll can't be read from Discord), skip posting results instead of creating and posting misleading all-zero results.This prevents confusing 'failure' messages with 0 voters and 0% participation when the actual issue is that Gary couldn't read the poll data from EasyPoll.
Changes
expiredResultsobject with all zerosTesting
Verified logic path in
apps/bot/src/lib/jobScheduler.tslines 504-522