Restore ASCOT5 adapters on top of canonical split#130
Open
krystophny wants to merge 21 commits into
Open
Conversation
9950b38 to
1c5714c
Compare
This reverts commit 80cc96d.
5aecbd9 to
f356454
Compare
…y/_magfie ascot5 imports h5py at module load and raises if the _magfie extension is absent; importing it unconditionally made the base package import hard-require optional deps. Guard the re-export so libneo imports cleanly without them.
Add test_field_from_vmec_local_fixture using the existing build/test/wout.nc ctest fixture so the VMEC (R,Z)->(s,theta) inversion and axis-NaN-fill in field_from_vmec get covered without LIBNEO_TEST_NETWORK. Revert an unrelated blank-line removal in CMakeLists.txt that this branch carried from an unrelated commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing