Skip to content

Restore ASCOT5 adapters on top of canonical split#130

Open
krystophny wants to merge 21 commits into
mainfrom
feature/ascot5-stack
Open

Restore ASCOT5 adapters on top of canonical split#130
krystophny wants to merge 21 commits into
mainfrom
feature/ascot5-stack

Conversation

@krystophny

Copy link
Copy Markdown
Member

Summary

  • reintroduce the Python ASCOT5 helpers and pytest coverage on top of the canonical-only base branch
  • wire the public package export so downstream users see
  • revive the detailed ASCOT5 TODO for follow-up work

Testing

  • source activate.sh && cmake --build build -j
  • source activate.sh && pip install -e .
  • source activate.sh && cd build && ctest --output-on-failure
  • source activate.sh && pytest -q

Base automatically changed from feature/canonical-split to main September 30, 2025 12:09
@krystophny krystophny force-pushed the feature/ascot5-stack branch 2 times, most recently from 9950b38 to 1c5714c Compare October 1, 2025 13:25
…y/_magfie

ascot5 imports h5py at module load and raises if the _magfie extension is
absent; importing it unconditionally made the base package import hard-require
optional deps. Guard the re-export so libneo imports cleanly without them.
@krystophny krystophny marked this pull request as ready for review June 29, 2026 11:21
Add test_field_from_vmec_local_fixture using the existing build/test/wout.nc
ctest fixture so the VMEC (R,Z)->(s,theta) inversion and axis-NaN-fill in
field_from_vmec get covered without LIBNEO_TEST_NETWORK.

Revert an unrelated blank-line removal in CMakeLists.txt that this branch
carried from an unrelated commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant