Track .bc retirement: chartmap vs .bc field-level gate#432
Closed
krystophny wants to merge 1 commit into
Closed
Conversation
Verify the .bc -> boozmn -> chartmap pipeline reproduces the .bc field: chartmap Bmod vs direct .bc Fourier agree to 1e-4 on committed fixtures (regenerated with the libneo radial-grid fix). Registered under pytest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #430.
Field-level
.bcretirement gate for SIMPLE: a pytest that checks the committed Boozer chartmap fixture (generated.bc -> boozmn -> chartmapwith the libneo radial-grid fix, itpplasma/libneo#347) has the variables SIMPLE's chartmap reader expects, thatBmodis positive, and that chartmapBmodmatches a direct.bcFourier evaluation to 1e-4.Clean branch off
main(the previous attempt was accidentally based on an in-progress FO-Boris branch). Additive only: the pytest, three committed fixtures, the CMakeadd_test, and.gitignoreexceptions for the fixtures.Verification