Add pids_limit and ulimits to docker-compose- edit to docker-compose.…#4557
Open
george-nehma wants to merge 2 commits intoisaac-sim:mainfrom
Open
Add pids_limit and ulimits to docker-compose- edit to docker-compose.…#4557george-nehma wants to merge 2 commits intoisaac-sim:mainfrom
george-nehma wants to merge 2 commits intoisaac-sim:mainfrom
Conversation
…yaml to fix child process on Rocky Linux 9.6 Signed-off-by: George Nehma <georgenehma98@gmail.com>
Contributor
Greptile OverviewGreptile SummaryThis PR adds resource limit configurations to the Docker Compose services to resolve child process fork errors on Rocky Linux 9.6. The changes add Key Changes:
These settings align with the existing configuration in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant DockerCompose as Docker Compose
participant Container as Isaac Lab Container
participant IsaacSim as Isaac Sim Process
participant ChildProc as Child Processes
User->>DockerCompose: docker-compose up
DockerCompose->>Container: Create container with config
Note over Container: pids_limit: 0<br/>ulimits.nproc: 65535<br/>ulimits.nofile: 65536
Container->>Container: Apply resource limits
Container->>IsaacSim: Start Isaac Sim
IsaacSim->>ChildProc: Fork nvidia-smi process
alt Before Fix (Rocky Linux 9.6)
ChildProc--xIsaacSim: ERROR: Resource temporarily unavailable
Note over IsaacSim: errno = 11<br/>Failed to fork child process
else After Fix
ChildProc-->>IsaacSim: Success
Note over IsaacSim: Child processes created<br/>within configured limits
end
IsaacSim->>Container: Continue execution
Container->>User: Container ready
|
Signed-off-by: George Nehma <georgenehma98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add to docker-compose.yaml to fix child process on Rocky Linux 9.6
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes #4485
Rocky Linux 9.6 gets an error with child processes under the current docker-compose.yaml file as in #4485.
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there