Conversation
There was a problem hiding this comment.
Pull request overview
Adds Cisco IOS XR support for standard BGP community-lists (“community-sets”) and enables using them in routing policy match clauses, aligning device feature flags and documentation with the new capability.
Changes:
- Enable IOS XR feature flags for standard community lists and routing-policy community matching.
- Implement IOS XR community-list normalization/quirks and route-policy object splitting logic for community lists.
- Add IOS XR Ansible templates to render community-sets and route-policy community match conditions; update docs for platform support matrices.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
netsim/devices/xr.yml |
Declares IOS XR support for standard community lists and policy match.community.standard. |
netsim/devices/iosxr.py |
Extends IOS XR quirks to validate/adjust community-list entries and split mixed permit/deny lists for policy rendering. |
netsim/ansible/templates/routing/iosxr/policy-match.j2 |
Adds route-policy match rendering for community and split permit/deny community matching. |
netsim/ansible/templates/routing/iosxr/clist.j2 |
New template to render IOS XR community-set definitions from routing.community. |
netsim/ansible/templates/routing/iosxr.j2 |
Includes the new community-set template when routing.community is present. |
docs/module/routing-policy.txt |
Updates IOS XR routing-policy match matrix to show standard community support. |
docs/module/routing-clist.txt |
Adds IOS XR to the community-filter platform support table and fixes IOS/XE naming. |
netsim/devices/iosxr.py
Outdated
Comment on lines
+98
to
+101
| """ | ||
| Check the values in community list entries | ||
| """ | ||
| def clist_check(node: Box) -> None: |
There was a problem hiding this comment.
The triple-quoted string immediately before clist_check is a standalone module-level string literal (not a function docstring) and becomes a no-op constant at import time; convert it to a # comment or move it inside clist_check as its docstring to avoid misleading documentation and lint noise.
Suggested change
| """ | |
| Check the values in community list entries | |
| """ | |
| def clist_check(node: Box) -> None: | |
| def clist_check(node: Box) -> None: | |
| """ | |
| Check the values in community list entries. | |
| """ |
ipspace
added a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.