Repository navigation
Dev - #73
Merged
Merged
Dev#73
Conversation
- Split groups with drop = TRUE, so unused factor levels and level combinations that don't occur no longer become empty groups that abort with "total demand and supply must be greater than 0". - Remove the input checks in doubly_constrained() that repeated the wrapper's, so each data-quality warning prints once. - Restore the full non-convergence warning and name the group (and decay value) in it and in the totals errors. - Put the group columns and decay_function_arg right after from_id/to_id, as for total and singly. - Docs: `active` is ignored; mismatched totals raise an error, checked within each group; the fill_missing_ids note doesn't apply to doubly; drop the ignored detailed_results from the example and add one with several decay values. - Tests for factor group columns, column order, single warnings and the group label in messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, light touch to testthat file and related doc.
- Rewrap the explanatory comments in doubly_constrained.R to 80 columns, in the file's style. - NEWS: fix the formatting and wording of the #66 bullet (what each constraint did before) and credit #67 in the breaking change. - Restore the test where demand and supply totals differ, and test that grouped results equal separate runs when groups have different ids and travel times, with each group balanced to its own totals. - test-constrained-wrapper.R: drop the suppressWarnings() left from the old marginals warning and check that doubly ignores detailed_results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
second-part fix of issue #66 for doubly-constrained accessibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.