Repository navigation
Conversation
soukhova
marked this pull request as draft
October 27, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of the fixes for issue #66 (subject: doubly-constrained accessibility).
Previously, the doubly-constrained iterative proportional fitting procedure (IPF) was run once across all transportation systems. This caused the land_use object to be integrated into the same run as many times as there were unique 'grouped' and 'multi-decay' parameters. This PR updates the logic such that each unique group or decay parameter is treated as an independent land-use-transportation-system, i.e., the function is run on each unique group and the the results are combined afterwards.
Changes:
run_standalone_doubly_ipf()run_grouped_doubly_ipf()group_bycombinationdecay_function_argdecay_function_argin outputAlso added tests covering -- all passed on the 3x3 toy example, function continues to pass on existing tests
As well, this implementation builds on the existing doubly-constrained fixes in dev mentioned in #67 (ensuring ID-based impedance matrix match and removal of the balancing-factor correction).
Closes #66 (and maybe #67 ?)