This repository was archived by the owner on Aug 17, 2023. It is now read-only.
Update deeplinks.js _queryToObject call#216
Open
omargon wants to merge 1 commit intoionic-team:masterfrom
Open
Update deeplinks.js _queryToObject call#216omargon wants to merge 1 commit intoionic-team:masterfrom
omargon wants to merge 1 commit intoionic-team:masterfrom
Conversation
Update deeplinks.js _queryToOjbect call to use `data.url` instead of data.queryString. On Android devices, the data.queryString is returning the queryString already decoded that when passed on to the _queryToObject function could result in some unwanted results. For example, a parameter string value that includes the `=` special character would get truncated unintentionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update deeplinks.js _queryToOjbect call to use
data.urlinstead ofdata.queryString. On Android devices, thedata.queryStringis returning thequeryStringvalue already decoded that when passed on to the _queryToObject function could result in some unwanted results. For example, a parameter string value that includes the=special character would get truncated unintentionally.