You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @ptmkenny! Sorry to do this twice, but I'm closing this one too and going with a different approach in #31361
Skipping the assignment for nullish values changes what undefined means for a prop that has a default. Right now <IonModal backdropDismiss={maybeUndefined} /> writes undefined over the @Prop() default of true, so with the assignment skipped the backdrop would start dismissing when it didn't before. It would also leave the generated components behaving differently, since those go through @lit/react, which assigns and then removes the attribute.
The new one mirrors @lit/react instead, and it has the tests you asked for. Thanks for the reproduction, it made this a lot easier to work through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31344
This is the v9 version of the PR #31345