chore(cli): migrate changes for Capacitor 9#8521
Open
jcesarmobile wants to merge 2 commits into
Open
Conversation
jcesarmobile
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
| if (txt.includes('@main')) { | ||
| return; // Probably already updated | ||
| } | ||
| // Since navigation was an optional change in Capacitor 7, attempting to add density and/or navigation |
Contributor
There was a problem hiding this comment.
This comment seems out of place? It sounds it's referring to changes in Android Manifest but this is AppDelegate.
| // eslint-disable-next-line prefer-const | ||
| let allDependencies: { [key: string]: any } = {}; | ||
| const libs = ['@capacitor/core', '@capacitor/cli', '@capacitor/ios', '@capacitor/android']; | ||
| const plugins = [ |
Contributor
There was a problem hiding this comment.
If this year we'll be launching next versions for all official plugins (I think we are aiming to do that?), should we update this list perhaps?
Contributor
There was a problem hiding this comment.
While I suppose for this PR it would mean pointing everything to next, when Cap 9 rolls out we'd need to adapt this script to map other plugin versions that aren't 9.x (e.g. barcode scanner)
That being said, since they are official plugins, they should be here in this script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The links to the docs don't exist yet, we should create them before releasing this, but the docs tasks are not on the sprint.
Also it will probably need some more changes in the future depending on what breaking changes we make in the plugins or if we make more changes on the templates.