You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This update displays the status badges for all parts wherever RenderStockItem is utilized. This allows statuses such as "Attention Needed" and "Damaged" to be visible in stock allocation dropdowns, while also displaying the appropriate status badge in other areas of the UI that use the same renderer.
Why was this PR needed?
People allocating stock within these order forms needed to know if the stock needed attention or was damaged.
1 paths audited Performance: 97 (no change from production) Accessibility: 81 (no change from production) Best Practices: 100 (no change from production) SEO: 78 (no change from production) PWA: - View the detailed breakdown and full score reports
Hi @SchrodingersGat, this is my first contribution to InvenTree. I fixed #10769 by displaying “Damaged” and “Attention Needed” stock status badges in the Build Order and Sales Order allocation dropdowns. Would appreciate a review when you have time. Thank you!
@SchrodingersGat Thank you for your feedback and my apologies for the delay. So to clarify, when you say display the stock status all the time, do you mean to display every other status, such as "Ok" and "Returned", as well? Or do you mean to eliminate the checks in BuildForms and SalesOrderForms and display the stock status everywhere that RenderStockItem is used?
@SchrodingersGat I simplified the implementation and now the badges render the stock status everywhere that RenderStockItem is used. Below are the other areas identified which will display the stock status as well, if you’d prefer only specific statuses to be shown, I’m happy to adjust it.
Stock Tracking after installation (Under "Details" column in "Stock Item" row)
I am happy with this approach. @matmair any objections?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SchrodingersGat
added
the
User Interface
What does this PR do?
This update displays the status badges for all parts wherever RenderStockItem is utilized. This allows statuses such as "Attention Needed" and "Damaged" to be visible in stock allocation dropdowns, while also displaying the appropriate status badge in other areas of the UI that use the same renderer.
Why was this PR needed?
People allocating stock within these order forms needed to know if the stock needed attention or was damaged.
What are the relevant issue numbers?
Closes #10769
Screenshots
Build Order allocation dropdown displays "Damaged" and "Attention Needed" badges
Sales Order allocation dropdown displays "Damaged" and "Attention Needed" badges
Does this PR meet the acceptance criteria?