[v12] feat(ui-popover,ui-options,ui-menu): rework Menu and Options#2391
Open
[v12] feat(ui-popover,ui-options,ui-menu): rework Menu and Options#2391
Conversation
|
ToMESSKa
commented
Feb 3, 2026
Comment on lines
63
to
+64
| background: componentTheme.selectedBackground, | ||
| color: componentTheme.highlightedLabelColor | ||
| color: componentTheme.selectedLabelColor |
Contributor
Author
There was a problem hiding this comment.
I changed this @hajnaldo as selectedLabelColor was not used before
ToMESSKa
commented
Feb 3, 2026
Comment on lines
-604
to
-605
| overflowX="hidden" | ||
| overflowY="hidden" |
Contributor
Author
There was a problem hiding this comment.
This was chaged by @adamlobler but it clipped the focus ring of the menu so I reverted this
ToMESSKa
commented
Feb 3, 2026
| import { withStyle } from '@instructure/emotion' | ||
|
|
||
| import generateStyles from './styles' | ||
| import generateComponentTheme from './theme' |
Contributor
Author
There was a problem hiding this comment.
I did not delete the theme.ts files of Options yet because Drilldown uses them. I will remove them in the Drilldown rework PR.
ToMESSKa
force-pushed
the
INSTUI-4796-menu-and-option-dropdown
branch
2 times, most recently
from
cdefaf3 to
0476c97
Compare
ToMESSKa
changed the title
ToMESSKa
force-pushed
the
INSTUI-4796-menu-and-option-dropdown
branch
from
0476c97 to
cef00c7
Compare
Contributor
Author
|
@hajnaldo I implemented the new selected, highlighted and selected+highlighted coloring of the Menu.Items, please check. |
matyasf
approved these changes
Feb 12, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
looks good, it looks like the design to me and all the tokens are used. FYI design might make some changes about how a selected item looks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4796
ISSUE:
Menu and Options needs to be migrated to the new theming system
TEST PLAN: