fix(influxdb3-ent): use image entrypoint and support extra env variables#799
fix(influxdb3-ent): use image entrypoint and support extra env variables#799alespour wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the influxdb3-enterprise Helm chart to rely on the container image entrypoint (enabling INFLUXDB3_UNSET_VARS) and adds per-component extraEnv support so environment overrides can be targeted to specific components.
Changes:
- Replace
command: /bin/sh -c ...withargs:across component StatefulSets to allow the image entrypoint to run, and introducePOD_NAMEvia the Downward API for stable--node-id. - Add component-scoped
extraEnvinvalues.yaml, document it in the README, and implement global+component env rendering in_helpers.tpl. - Add CI coverage values for component
extraEnv, bump chart/app versions, and update cert-manager install/wait logic in CI.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/influxdb3-enterprise/values.yaml | Adds per-component extraEnv and clarifies global vs component env behavior. |
| charts/influxdb3-enterprise/templates/_helpers.tpl | Introduces podNameEnv and componentExtraEnv helper templates. |
| charts/influxdb3-enterprise/templates/ingester-statefulset.yaml | Switches to args, uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/templates/querier-statefulset.yaml | Switches to args, uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/templates/compactor-statefulset.yaml | Switches to args, uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/templates/processor-statefulset.yaml | Switches to args (incl. init container), uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/README.md | Documents global and component-specific extraEnv and updates parameters table. |
| charts/influxdb3-enterprise/ci/component-extra-env-values.yaml | Adds CT install values to exercise per-component env + entrypoint unset behavior. |
| charts/influxdb3-enterprise/Chart.yaml | Bumps chart version and appVersion. |
| .github/workflows/helm-charts-test.yaml | Updates cert-manager install URL and replaces sleep with kubectl wait. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bednar
left a comment
There was a problem hiding this comment.
Requesting changes for the component extraEnv override behavior. The current implementation can render duplicate Kubernetes env entries for the same name, which is brittle for apply/GitOps/server-side tooling and does not actually model a clean override.
bednar
left a comment
There was a problem hiding this comment.
Looks good. I re-reviewed the updated extraEnv override implementation and verified the rendered manifests no longer contain duplicate env names for the CI values. Existing review threads are already resolved.
Closes #798
entrypointfor containers. One of the benefits is thatINFLUXDB3_UNSET_VARSworks now.extraEnvvalues support; global with per-component overrides