Repository navigation
mipv6: send mobility signaling to the next hop instead of to the whole link #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamgeorge309
wants to merge
2
commits into
master
Choose a base branch
from
topic/gy/mipv6-unicast-signaling-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Mobility signaling ignores redirected next hops
After an IPv6 Redirect,
getNextHopOnInterfacestill selects the original route's router. processRedirectPacket updates the destination cache, which this lookup ignores. Mobility messages can miss their destination when the former router stops forwarding.Learn more
An IPv6 Redirect changes the next hop for one destination by updating the destination cache, not the routing table. The normal IPv6 output path reads that cache in determineOutputInterface. Mobility messages pin an interface, bypassing that path, and this lookup selects the old route instead. Thus a mobility packet can take a different first hop from ordinary packets to the same destination.
Example: A correspondent node reaches a mobile node's care-of address through router A. Router A redirects that destination to router B on the same link. Ordinary packets use B, but a later Binding Acknowledgement still uses A; if A stops forwarding, the acknowledgement does not arrive.
Recommended fix: In
getNextHopOnInterface, consultlookupDestCachebefore the route scan and accept its next hop only if its cached interface matchesinterfaceId. Fall back to the longest matching route on the pinned interface otherwise, and test a redirected destination with a subsequent pinned mobility message.Was this helpful? React with 👍 or 👎 to provide feedback.