Fix GH-23331: UAF when an attribute child keeps a live wrapper - #236
Closed
iliaal wants to merge 1 commit into
Closed
Fix GH-23331: UAF when an attribute child keeps a live wrapper#236iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
node_list_unlink() detaches attribute children that still have a PHP wrapper so libxml2 does not free them underneath it, but two exits abandoned the rest of the list: xmlUnlinkNode() clears node->next, and the XML_ENTITY_REF_NODE case broke out of the loop instead of only skipping the borrowed entity children. Anything past either exit was freed by xmlSetProp(), xmlSetNsProp() or xmlFreeProp() with a live wrapper still pointing at it. Fixes phpGH-23331
iliaal
force-pushed
the
fix/gh-23331-dom-attr-child-uaf
branch
from
August 17, 2026 19:23
aa208fd to
ec8556a
Compare
Owner
Author
|
Promoted upstream: php#23337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_list_unlink() abandoned an attribute's remaining children at two exits: xmlUnlinkNode() clears node->next, and the entity-reference case broke out of the loop instead of only skipping the borrowed entity children. Anything past either exit was freed by xmlSetProp()/xmlSetNsProp() with a live wrapper still pointing at it. The #37456 recursion guard is kept.