Update to Node.js 24 - #106
Open
ckormanyos wants to merge 1 commit into
Open
Conversation
Author
|
Hi @ilammy I think this update is needed nowor soon. Thank you very much for supporting this project. |
Author
|
See also #104. Sorry if this is redundant |
Copilot AI
added a commit
to canonical/multipass
that referenced
this pull request
Jun 1, 2026
…0 workaround - Remove the built-in <ServiceConfig> element from DaemonComponents.wxs. WiX documents its functionality as "not [working] as expected" per the Windows Installer SDK. The <util:ServiceConfig> element already correctly handles service restart actions via custom actions. - Add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true to the Windows CI job environment. The ilammy/msvc-dev-cmd@v1 action uses Node.js 20, which GitHub is removing support for (scheduled September 16, 2026). The upstream PR to update to Node.js 24 is in progress: ilammy/msvc-dev-cmd#106
7 tasks
This was referenced Jun 1, 2026
Closed
BenJule
added a commit
to BenJule/BambuStudio
that referenced
this pull request
Jun 1, 2026
Closes #363 ## Summary - `ilammy/msvc-dev-cmd@v1.13.0` uses `node20`, which is deprecated in GitHub Actions (forced to Node.js 24 on June 16, 2026; removed September 16, 2026) - Upstream has no Node.js 24 release yet (ilammy/msvc-dev-cmd#106 pending) - The action's JavaScript is already Node.js 24 compatible — only the `action.yml` version declaration is outdated - Fix: add `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: 'true'` to the step env, as recommended by GitHub ## Change `.github/workflows/_build-core.yml` — adds one env line to the `Setup MSVC developer environment` step. ## Test plan - [ ] Windows build (windows-2022) succeeds without Node.js deprecation warning - [ ] Windows ARM build (windows-11-arm) is unaffected (fails on OpenCV, not on this step)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to Node.js 24