fix: make worker documentation entrypoint optional - #824
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe PR makes ChangesOptional skill documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 61 skipped (no docs/).
Four for four. Nicely done. |
Summary
skills/SKILL.mdentrypoint optional for every workerRoot cause
The registry payload builder rejected any worker that had markdown under
skills/without a rootskills/SKILL.md. The console release containsskills/design-console-ui/SKILL.mdbut no root entrypoint, so the release failed after the worker package had already been published.Impact
Future releases can publish nested worker documentation independently. Workers that still provide
skills/SKILL.mdretain the existing registry key mapping, and releases with no non-empty markdown continue to skip the documentation upload.Validation
python3 .github/scripts/test_build_skills_payload.py— 4 passedpython3 -m pytest .github/scripts/tests -q— 195 passed, 3 subtests passedskills/design-console-ui/SKILL.mdpython3 -m py_compilefor the modified Python filesgit diff --checkSummary by CodeRabbit
New Features
SKILL.mdoverview.Documentation
Bug Fixes
SKILL.mdcan now pass validation when otherwise valid.