Skip to content

feat(console): add observability configuration form - #1055

Open
ytallo wants to merge 1 commit into
mainfrom
feat/console-observability-config-ui
Open

feat(console): add observability configuration form#1055
ytallo wants to merge 1 commit into
mainfrom
feat/console-observability-config-ui

Conversation

@ytallo

@ytallo ytallo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • registers iii-observability in the Console-owned configuration form manifest
  • exposes trace, metric and log exporters, sampling, alerts, runtime logging and durable trace storage
  • keeps disk retention and memory low-watermark controls in the Worker Console

Engine UI removal: iii-hq/iii#2125

Validation

  • pnpm --filter @iii-workers/console-worker-ui test
  • pnpm --filter @iii-workers/console-worker-ui build
  • cargo test -p console
  • Chromium desktop and mobile configuration smoke tests

Known follow-ups

  • the shared variant editor currently retains an empty config: {} object after changing an internally tagged alert action
  • shared collection metadata text does not yet meet WCAG AA contrast

Summary by CodeRabbit

  • New Features

    • Added an Observability worker configuration form to the console.
    • Added configuration options for telemetry collection, exporting, service identity, trace storage, sampling, metrics, logs, alerts, and span rules.
  • Tests

    • Updated configuration coverage checks to include the new Observability worker form.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
workers Ready Ready Preview Sep 3, 2026 1:42am UTC
workers-tech-spec Ready Ready Preview Sep 3, 2026 1:42am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f762ce7e-9ff7-4012-82f8-f3dfa0443399

📥 Commits

Reviewing files that changed from the base of the PR and between 112cd89 and fd7e9a5.

📒 Files selected for processing (5)
  • console/src/ui.rs
  • console/ui/config-form.tsx
  • console/ui/configuration-forms.test.mjs
  • console/ui/src/configuration-forms/manifest.ts
  • console/ui/src/configuration-forms/specs/observability.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The PR adds a complete observability worker configuration specification. It registers the form in the console and updates manifest coverage checks from 39 to 40 workers.

Changes

Observability configuration

Layer / File(s) Summary
Define observability configuration
console/ui/src/configuration-forms/specs/observability.ts
Adds collection, storage, sampling, metrics, logs, runtime logging, alerts, and trace presentation fields with defaults, constraints, variants, and expected field paths.
Register the worker configuration
console/ui/src/configuration-forms/manifest.ts, console/ui/config-form.tsx
Adds observabilityWorkerSpec to the worker manifest and registers the iii-observability configuration form.
Update registration coverage
console/ui/configuration-forms.test.mjs, console/src/ui.rs
Adds iii-observability to expected IDs and updates worker configuration counts from 39 to 40.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to fd7e9

This adds the Observability configuration form and its Console registration. The supplied coverage indicates the form contract is wired correctly; the remaining known issues are a redundant empty config object after some alert-action edits and metadata contrast below WCAG AA, which are bounded follow-ups rather than merge blockers.

Suggested reviewers: sergiofilhowz

Poem

A rabbit inspects the tracing chart
New fields hop neatly into place
Alerts twitch, and metrics start
Sampling rules line up in grace
Forty forms now share the space

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding an observability configuration form to the Console.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/console-observability-config-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 70 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant