Support clicks UNSET condition for is_flag and default#22
Merged
Conversation
Member
Author
|
Some other tests are not passing either on this branch... Not sure why. Changes are limited to the bump click 8.1.x -> 8.3.0 |
anjos
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Member
Author
|
@Yannick-Dayer: I managed to fix this package without requiring a new version of auto-intersphinx for now. I need this one a bit more urgently than auto-intersphinx. If you can tag and release this first, it would help us! |
Member
Author
|
@Yannick-Dayer: please wait - there is now a regression with click <8.3... |
Member
Author
|
@Yannick-Dayer: this is now also fixed - ready to be merged. |
Yannick-Dayer
approved these changes
Oct 16, 2025
Yannick-Dayer
left a comment
Yannick-Dayer
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I just find weird to include the "dev" dependencies in the default environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a regression on click 8.3.x that disallows the use of "secondary" flag options in the style
-a/-Afor set/unset flag. I'm not sure why the problem appears yet, but there is a new test in this branch that shows it.📚 Documentation preview 📚: https://clapper--22.org.readthedocs.build/en/22/