Conversation
mcherri
requested changes
Oct 15, 2021
| m.top.response = response | ||
| return response | ||
| end if | ||
| m.top.response = response |
Collaborator
There was a problem hiding this comment.
response can be uninitialized here.
Owner
Author
There was a problem hiding this comment.
yeah, we don't need it's return
Comment on lines
+4
to
+8
| m.http.request = { payload: { | ||
| userId: 1, | ||
| title: "WOW, IT WORKED ^_^", | ||
| }, url: "https://jsonplaceholder.typicode.com/albums", requestType: "GET"} | ||
| m.global.http.observeFieldScoped("response", "useResponse") | ||
| }, url: "https://www.youtube.com/watch?v=1FL22N1EXDo", requestType: "GET" } | ||
| m.http.observeFieldScoped("response", "useResponse") |
Collaborator
There was a problem hiding this comment.
We should request after we observe the field.
Comment on lines
32
to
33
| requestId = httpRequest.getIdentity().ToStr() | ||
| m.urlRequest[requestId] = { |
Collaborator
There was a problem hiding this comment.
Better:
m.urlRequest[httpRequest.getIdentity().ToStr()] = {| return response | ||
| end if | ||
| m.top.response = response | ||
| return response |
Collaborator
There was a problem hiding this comment.
Does this mean that we can handle only a single request? If yes then m.urlRequest AA is useless.
Owner
Author
There was a problem hiding this comment.
I guess we'll save the request's result in the response's AA and after resolving it we'll clear it's index
| <field id="request" type="assocarray" /> | ||
| <field id="response" type="assocarray" /> | ||
| </interface> | ||
| <children></children> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.