Details background#5
Open
ibrkhalil wants to merge 17 commits into
Open
Conversation
mcherri
requested changes
Sep 29, 2021
mcherri
reviewed
Sep 30, 2021
mcherri
requested changes
Oct 7, 2021
| @@ -1,12 +1,21 @@ | |||
| sub init() | |||
Collaborator
There was a problem hiding this comment.
The logic in this file is complex. Please simplify it.
Owner
Author
There was a problem hiding this comment.
I've added some comments to explain it
or did you mean to rewrite it in a simpler way ?
Collaborator
There was a problem hiding this comment.
I will help you with this.
Owner
Author
There was a problem hiding this comment.
Thanks so much ..
I'll be waiting
mcherri
requested changes
Oct 15, 2021
|
|
||
| ' Handling Responsivness | ||
| videoMode = createObject("roDeviceInfo") | ||
| if videoMode.GetVideoMode() = "720p" |
Collaborator
There was a problem hiding this comment.
I will simplify this code for you when I have time. There is a better way to do it.
Comment on lines
+37
to
+44
| sub handleHeroDetails() | ||
| if m.flag | ||
| m.flag = false | ||
| handleUpdate() | ||
| else | ||
| handleItemFocusChange() | ||
| end if | ||
| end sub |
Collaborator
There was a problem hiding this comment.
An example of complexity is this function. It handles two different concerns.
Owner
Author
There was a problem hiding this comment.
I see what you mean, Mr. Mostafa
Collaborator
|
Let us discuss what I changed and why next Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.