add option to fits reader to open L1 products also in UTC >L1 UTC per default (via keyword in header)

[nicHoch]

add keyword: get_timeformat_from_TIMESYS to Product(path) method.
If set time and timedel column in data table are converted to timesystem provided in the TIMESYS header keyword.

some products properties like utc_timerange, min_exposure ... might do autoconversions based on the internal timesystem but it should be avoided to open L1 files in UTC for processing them further.

Use get_timeformat_from_TIMESYS=True only for reading excess to L1 data, read/write/combing might lead to timing accuracy issues

[codecov-commenter]

Codecov Report

❌ Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.04%. Comparing base (3ae9671) to head (9b9c9dc).
⚠️ Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
stixcore/products/product.py	86.95%	6 Missing ⚠️
stixcore/products/level1/quicklookL1.py	20.00%	4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3ae9671) and HEAD (9b9c9dc). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (3ae9671)	HEAD (9b9c9dc)
	2	1

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   72.23%   67.04%   -5.19%     
==========================================
  Files          78       76       -2     
  Lines        8085     8136      +51     
==========================================
- Hits         5840     5455     -385     
- Misses       2245     2681     +436     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[samaloney]

I'm not sure allowing operations in different time systems is a good idea. A product should either have time in OBT or UTC and the conversion should only be done once in the from_level0 or similar methods?

All products (>L0) will always have obt_timerange from products will have an utc_timerange but only if the time sys in header is UTC and not sure supporting on the fly conversion is a good idea because the spice kernel dependence.

This aren't blocker just thoughts

[nicHoch]

i agree that it is not ideal to provide some of the on the fly conversions. The auto converting most of the time (and if proper used never) will not happen as our process steps will do this explicit.

In general this L1 product could have state depended time systems and i think it would be bad experience if the properties will raise an exception if used