Skip to content

test(agent): fix a flaky test of the host socket's lock #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalaspuff merged 1 commit into from
Oct 18, 2026
Merged

test(agent): fix a flaky test of the host socket's lock #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/fctl-agent/src/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,16 @@ mod tests {
// Once the first is gone, the next one serves, over its stale socket.
drop((listener, lock));
assert!(socket.exists());
assert!(matches!(claim(&socket).await?, Claim::Serving(_, Some(_))));
Ok(())
// Processes that other tests start hold copies of the first's lock and
// socket until they exec, so it can look taken a moment longer.
for _ in 0..100 {
match claim(&socket).await? {
Claim::Serving(_, Some(_)) => return Ok(()),
Claim::Serving(_, None) => anyhow::bail!("the next supervisor got no lock"),
Claim::Taken => tokio::time::sleep(Duration::from_millis(20)).await,
}
}
anyhow::bail!("the next supervisor should get the socket once the first is gone")
}

#[tokio::test]
Expand Down