[fctl-sh]

Summary

Session titles reached people's terminals as the server had them. fctl sessions, fctl show, the header of fctl attach and fctl run, and the host commands' lists printed them raw, and the titles the control plane makes itself skipped the control-character check that titles people set get: one made from a prompt's first line, from a Linear ticket's title, a schedule's prompt or a reviewed pull request's title. So a project editor, the author of a pull request a review agent reviews, or whoever writes a Linear ticket that someone delegates could put escape sequences in a title that, when another member listed sessions, set their clipboard (in terminals that allow OSC 52), rewrote their screen, set the window's title or planted links.

• Titles fctl makes leave out control characters and those that turn text around (fctl_domain::naming::plain), as names already did.
• The CLI prints titles, descriptions, branches, names, models and what fctl login shows (the instance's name, the code, the link, who signed in) through style::plain, one line without any control characters, and error messages through terminal_safe, as transcripts already were (fix(cli): open only the server's sign-in links and print sessions safely #174). Titles stored before this print clean too.

Verified against cargo xtask dev: a session started with a prompt that begins with an OSC 52 sequence gets a title without it, and with a raw escape sequence put into a stored title, fctl sessions and fctl show print it without any escape or bell character. New unit tests cover the domain's titles, review titles and the CLI's plain; cargo xtask check --quick passes.

Stacked pull requests

Based on the one before it in this security pass's stack:

• fix: confirm it's you before linking a Linear account #357

fctl session

---

Note

Low risk. It only changes how titles and names are cleaned or printed, in the CLI and in the titles the control plane derives, with no stored-data or protocol change.

What it does. Titles the control plane derives from prompts, Linear tickets, schedules and reviewed pull requests now drop control characters and characters that reverse text, so escape sequences in them can no longer act on a terminal. The CLI also prints titles, descriptions, branches, names, models, login details and error messages through style::plain or terminal_safe, now including the fctl run confirmation line and fctl edit output, so titles stored before this print clean too.

_{fctl review's first look at 10587ed · 8 files, +114 −25 · Review agent settings}

[fctl-review]

fctl reviewed f591f07 and found 2 issues.

The domain side (naming::plain, title_from_prompt, reviews::title) looks right and its tests pass. The CLI side leaves a few title sinks unsanitized, including the fctl run header the description says is covered.

On lines the diff doesn't show:

• fctl run still prints the title raw · Medium severity · crates/fctl/src/cmd/sessions.rs line 280: The confirmation line built in run formats session.title into style::bold(...) without style::plain. The description says the fctl run header is covered, but this title can be one the control plane derived from a prompt or ticket, so escape sequences in it still reach the terminal.
• print_edited prints title and description raw · Low severity · crates/fctl/src/cmd/sessions.rs lines 691–693: print_edited (used by fctl edit) prints title and description as the server returns them, while fctl show now prints the same values through style::plain. A title or description another member set reaches the terminal unchanged.

_{Reviewed by fctl · Review agent settings}

[fctl-sh]

On the review's two summary findings, both fixed in 10587ed: the line fctl run prints for the session it started now shows the title through style::plain, and print_edited (fctl edit) prints the title and description through it too. The other places that print names (people's, workspaces', projects', runners', devices') take names the control plane cleans as it stores them since #239, so I left them as they are.