[cicd] Add Secret Scanner#394
Conversation
|
this is failing as expected, as it is run from a fork. So the gitleaks_license is not exposed. it should run ok in main. |
kevinhermawan
left a comment
There was a problem hiding this comment.
Thanks for adding secret scanning. One blocker before approval: currently fails on forked PRs because fork runs don't get and/or write permissions for PR comments, but the workflow enforces failure ( + ). This makes external/fork contributions permanently red even when no secrets are found. Please make fork runs non-blocking (or disable comments/license-dependent behavior on forks) and keep blocking behavior for trusted branches.
|
Clarification: the blocker is that |
fixed. |
Summary
Prevent accidently pushing secrets to the repository
Checklist (
.cursorrules)pnpm code-qualitylocally and it passed.pnpm cursor:review -- --base origin/main --head HEAD(or equivalent SHAs) and fixed any issues.route.*.config.tsfiles, I followed the route-action-gen workflow (config + generator + tests).agent-data-apiroutes, the shared contract, or the SDK, I updated schemas, manifest, handlers, consumers, anddev-docs/docs/mediapulse/apps/agent-data-api.mdxtogether.Notes for reviewers