Repository navigation
Conversation
Return an owned lazy future from PingPong::ping, matching each ACK by a unique payload. Bound pending state and retain legacy send_ping/poll_pong cancellation and drain behavior. Reuse existing shared ownership and connection/legacy wakers. Add focused out-of-order ACK, cancellation, bounds and golden compatibility tests. Validated with full library/integration/doc suites, supplemental localhost TCP tests, Hyper keepalive checks and a pinned Rust 1.63 library build.
jimages
force-pushed
the
feature/concurrent-user-pings
branch
from
November 2, 2026 04:14
74c3b67 to
3833a10
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP/2 protocol allows multiple PING frames to be in flight concurrently on a single connection. However, H2 currently supports only one outstanding PING at a time.
For example, if a developer wants to send three PINGs, they must wait for each PING to complete before sending the next one. This introduces unnecessary delays compared to sending the PINGs at fixed intervals (e.g., every 30 ms), without waiting for the previous PING to complete.
Could we add support for concurrent PINGs in H2? Node.js already supports this functionality, allowing up to 10 outstanding PINGs per session.
Reference: https://nodejs.org/api/http2.html#http2sessionpingpayload-callback