Skip to content

fix: import parquetDataSource from the built package#379

Merged
severo merged 3 commits intomasterfrom
fix-import
Mar 17, 2026
Merged

fix: import parquetDataSource from the built package#379
severo merged 3 commits intomasterfrom
fix-import

Conversation

@severo
Copy link
Contributor

@severo severo commented Mar 16, 2026

fix #378

@severo severo requested a review from platypii March 16, 2026 14:18
@severo severo changed the title get parquetDataSource from the build package get parquetDataSource from the built package Mar 16, 2026
@severo
Copy link
Contributor Author

severo commented Mar 16, 2026

Note that I adapted the "typecheck" script because the files in bin/ require the lib and the types to be built, now that they depend on hyperparam.

@severo severo requested review from Copilot and removed request for platypii March 17, 2026 10:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the reported install/runtime issue (#378) by ensuring the CLI tool imports parquetDataSource from the published package surface rather than from source files that aren’t present in the built artifact.

Changes:

  • Update bin/tools/parquetSql.js to import parquetDataSource from hyperparam instead of ../../src/index.js.
  • Update npm run typecheck to build before running tsc --noEmit (and add typecheck-once-built).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Adjusts typechecking scripts to ensure built type artifacts exist before tsc --noEmit.
bin/tools/parquetSql.js Switches parquetDataSource import to come from the published package entrypoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@severo severo changed the title get parquetDataSource from the built package fix: import parquetDataSource from the built package Mar 17, 2026
@severo severo merged commit e5ed67a into master Mar 17, 2026
4 checks passed
@severo severo deleted the fix-import branch March 17, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with the install?

2 participants