Enable Jackson 3 - Phase 2 #2183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design GitHubJackson interface with methods for reading/writing JSON Implement GitHubJackson2 and GitHubJackson3 Create DefaultGitHubJackson factory with programmatic selection Create GitHubJacksonException wrapper classes Add GitHubBuilder.withJackson() for configuring Jackson implementation Add testing infrastructure for both Jackson versions
bitwiseman
reviewed
Jan 26, 2026
| * @see DefaultGitHubJackson#createJackson2() | ||
| * @see DefaultGitHubJackson#createJackson3() | ||
| */ | ||
| public GitHubBuilder withJackson(GitHubJackson jackson) { |
Member
There was a problem hiding this comment.
You can't have something in the internal package a public method.
I'd suggest just having DefaultGitHubJackson control this and not provide a public method to control this.
Contributor
Author
There was a problem hiding this comment.
I went with an alternative to keep the programmatic access option
bitwiseman
reviewed
Jan 27, 2026
| * @throws IllegalStateException | ||
| * if Jackson 3.x is not available on the classpath | ||
| */ | ||
| public GitHubBuilder useJackson3() { |
Member
There was a problem hiding this comment.
See comment on DefaultGitHubJackson.createDefault():
Suggested change
| public GitHubBuilder useJackson3() { | |
| public GitHubBuilder useJackson2() { |
bitwiseman
reviewed
Jan 27, 2026
|
|
||
| private GitHubConnector connector; | ||
|
|
||
| private GitHubJackson jackson; |
Member
There was a problem hiding this comment.
Suggested change
| private GitHubJackson jackson; | |
| private GitHubJackson jackson = DefaultGitHubJackson.createDefault(); |
bitwiseman
reviewed
Jan 27, 2026
| rateLimitChecker, | ||
| authorizationProvider); | ||
| authorizationProvider, | ||
| jackson != null ? jackson : DefaultGitHubJackson.createDefault()); |
Member
There was a problem hiding this comment.
Suggested change
| jackson != null ? jackson : DefaultGitHubJackson.createDefault()); | |
| jackson); |
bitwiseman
reviewed
Jan 27, 2026
| * @return a GitHubJackson2 instance | ||
| */ | ||
| public static GitHubJackson createDefault() { | ||
| return new GitHubJackson2(); |
Member
There was a problem hiding this comment.
I think we should default to Jackson3 if it is available, but I'm open to discussion.
Suggested change
| return new GitHubJackson2(); | |
| if (isJackson3Available()) { | |
| return new GitHubJackson3(); | |
| } else { | |
| return new GitHubJackson2(); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2173 for the initial PR and associated discussion.
This PR is the follow-up of #2182.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: