This repository was archived by the owner on Sep 20, 2021. It is now read-only.
chore(php-compat): private method should not be final#35
Open
mathroc wants to merge 1 commit intohoaproject:masterfrom
Open
chore(php-compat): private method should not be final#35mathroc wants to merge 1 commit intohoaproject:masterfrom
mathroc wants to merge 1 commit intohoaproject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is not supposed to be merged, it’s the same as #30 but applied on the last release instead of master so it can be used easily in existing project migrating to php 8.
in your composer.json, add this entry to tell composer about the fork:
and add (or update) the
hoa/streamin your dependencies like this:you can then run
composer update hoa/streamto use hoa/stream in a php8 project without having the warning mentioned in #32