Repository navigation
test(scripts): assert smoke.sh restores an already-on watch pref as -bool true - #361
Merged
Merged
Conversation
…bool true Closes #360 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup()inscripts/smoke.shrestores each watch pref three ways (delete /-bool true/-bool false), but the suite only seeded the unset and0cases, so the-bool truearm — the state most developers actually have — was the one lineshell-coverage.shreported uncovered. A regression there would leave a developer's auto-watch/clipboard-watch switched off after running the smoke, and the current suite would not notice: swappingtrue→falseon that line passes 25/25.This adds one hermetic case seeding
hotshotClipboardWatch=1and asserting the key is written-bool trueexactly twice (pin, then restore), never-bool false, never deleted, and ends on. Platform: scripts only (macOS smoke, tested on Linux via the stubdefaults).Closes #360
Validation
bash scripts/tests/smoke.test.sh→ 28 passed, 0 failedscripts/smoke.sh:60to-bool false→ 3 new assertions fail (25 passed, 3 failed); revertedbash scripts/shell-coverage.sh→scripts/smoke.sh: 100% (60/60)(was 98%, 59/60); all other scripts unchanged at 100%if grep -q …; then check … 1; else check … 0; fiidiom — left to CIChecklist
bash scripts/shell-coverage.sh)runbooks/in this PR (n/a)git commit -s)Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88