Skip to content

test(scripts): assert smoke.sh restores an already-on watch pref as -bool true - #361

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
quality/test-smoke-restore-on-pref
Nov 5, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
quality/test-smoke-restore-on-pref

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary

cleanup() in scripts/smoke.sh restores each watch pref three ways (delete / -bool true / -bool false), but the suite only seeded the unset and 0 cases, so the -bool true arm — the state most developers actually have — was the one line shell-coverage.sh reported uncovered. A regression there would leave a developer's auto-watch/clipboard-watch switched off after running the smoke, and the current suite would not notice: swapping true→false on that line passes 25/25.

This adds one hermetic case seeding hotshotClipboardWatch=1 and asserting the key is written -bool true exactly twice (pin, then restore), never -bool false, never deleted, and ends on. Platform: scripts only (macOS smoke, tested on Linux via the stub defaults).

Closes #360

Validation

  • bash scripts/tests/smoke.test.sh → 28 passed, 0 failed
  • Mutation: changing scripts/smoke.sh:60 to -bool false → 3 new assertions fail (25 passed, 3 failed); reverted
  • bash scripts/shell-coverage.sh → scripts/smoke.sh: 100% (60/60) (was 98%, 59/60); all other scripts unchanged at 100%
  • ShellCheck not available locally; new lines reuse the file's existing if grep -q …; then check … 1; else check … 0; fi idiom — left to CI

Checklist

  • The checks for every platform this change touches pass locally (bash scripts/shell-coverage.sh)
  • New or changed lines are covered by tests
  • Changes to path injection or CLI detection keep macOS, Linux and Windows aligned with the README contract (n/a)
  • A renamed or new diagnostic event is reflected in runbooks/ in this PR (n/a)
  • Commits are signed off (git commit -s)

Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…bool true

Closes #360

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 5, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit f7bcffd into main Nov 5, 2026
12 of 13 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the quality/test-smoke-restore-on-pref branch November 5, 2026 09:33
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#36144fd2b7` sha256:de5ac0ba627d0d1ce50600069211ea5084441ff587ca1cc43b5e8be0e01a2ef3 — download from the dashboard or `hivectl review evidence #361`.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] smoke.sh: restore of an already-on watch pref (-bool true arm) is never exercised by smoke.test.sh

0 participants