Conversation
…into no-priv-escalation
Set allowPrivilegeEscalation to false by default
Add label to rename pvc mount dir
Drop the apps/deployments rule entirely - webhook-server never calls the Deployments API (it receives the Deployment object directly in the AdmissionReview payload), verified via a repo-wide grep of every CoreV1()/AppsV1() call site. Drop `get` on secrets/persistentvolumeclaims/configmaps - FindMatchingResources always lists + regex-matches, even for a plain literal volume source with no capture group, so there's no get-by-name call site. `list` itself can't be scoped further since Kubernetes RBAC doesn't support resourceNames on that verb; closing that fully needs a code change to add a get-based fast path for non-regex sources. Verified with kubectl auth can-i checks against a scratch ServiceAccount, plus a live behavioral test in cddp-stage: applied the tightened rules to the running deployment and triggered a real admission review by launching an appstore app instance. Admission processed cleanly (LDAP lookup, patch marshalling) with no errors, and the resulting instance worked normally. Chart version 1.6.1 -> 1.6.2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fix vulns detected by trivy scan
Helx-1.1.1 release
joshua-seals
requested changes
Aug 19, 2026
joshua-seals
left a comment
joshua-seals
left a comment
Collaborator
There was a problem hiding this comment.
Migrate the CI into this repo - get away from the centralized github actions. Just want to also clarify, the updated applications were tested? For the most part the go updates seem fine but never a bad idea to just spin it up and ensure it's working. I do agree the updates were needed and security improvements though. 🌟
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.