-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Update CONTRIBUTING.md #31668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update CONTRIBUTING.md #31668
Conversation
Signed-off-by: vaibhav154 <36911520+vaibhav154@users.noreply.github.com>
banjoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| - Applying labels and milestones | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Applying labels and milestones | |
| - Applying labels and milestones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That suggestion didn't come out like I expected. My request is no empty lines in the middle of the list
| - Reviewing new issues and PRs | ||
|
|
||
| - Applying labels and milestones | ||
|
|
||
| - Keeping queues manageable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Reviewing new issues and PRs | |
| - Applying labels and milestones | |
| - Keeping queues manageable | |
| - Reviewing new issues and PRs | |
| - Applying labels and milestones | |
| - Keeping queues manageable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as @TerryHowe 's suggestion -- remove the blank lines between list items please
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)