fix(sticky_header): use vim.schedule for window close during BufUnload#84
Merged
fix(sticky_header): use vim.schedule for window close during BufUnload#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:e!commandvim.scheduleto defer window close operation to avoid Neovim event callback restrictionsDescription
When reloading a buffer with :e!, the sticky header window was not being closed properly. This occurred because nvim_win_close was being called during the BufUnload event callback, where certain window operations may be restricted or silently fail.
The fix defers the window close operation using vim.schedule, ensuring it executes in the next event loop iteration when window operations are permitted.
Additionally,
M._sticky_header_wins[winid]is now cleared before scheduling the close to prevent any race conditions.Test plan
:e!to reload the buffer