Repository navigation
Don't start a new word at chunk boundaries in lazy toTitle - #722
Merged
Merged
Conversation
Lazy toTitle ran the strict toTitle on every chunk separately, and the strict version treats the start of its input as the start of a word. So whenever a chunk boundary fell inside a word, the letter after it was capitalised: toTitle (fromChunks ["hel", "lo wor", "ld"]) gave "HelLo WorLd". Make the strict implementation take and return whether it is in the middle of a word, and have lazy toTitle carry that from one chunk to the next. Strict toTitle starts outside a word as before, so its behaviour is unchanged. Add a property that lazy toTitle agrees with strict toTitle regardless of chunking, plus the example above. Fixes haskell#721
Lysxia
reviewed
Nov 19, 2026
Lysxia
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy toTitle ran the strict toTitle on every chunk separately, and the strict version treats the start of its input as the start of a word. So whenever a chunk boundary fell inside a word, the letter after it was capitalised: toTitle (fromChunks ["hel", "lo wor", "ld"]) gave "HelLo WorLd".
Make the strict implementation take and return whether it is in the middle of a word, and have lazy toTitle carry that from one chunk to the next. Strict toTitle starts outside a word as before, so its behaviour is unchanged. Add a property that lazy toTitle agrees with strict toTitle regardless of chunking, plus the example above.
Fixes #721