Repository navigation
Count downloads from content delivery networks via a redirection scheme - #1525
Draft
LaurentRDC wants to merge 1 commit into
Draft
LaurentRDC wants to merge 1 commit into
LaurentRDC wants to merge 1 commit into
Conversation
This patch addresses the issue whereby tarball downloads served by a content delivery network were not counted in statistics. The patch implements a redirect scheme, where requests to the main host now return a HTTP302 redirect response, with a Cache-Control: No-Store header, and counts the download. Then, the request is redirected to the user-content host for the download, which can be served either by Hackage itself or by some other cache. This will result in /more/ traffic to Hackage due to the cache policy on the redirection. The download count feature has been optimized in haskell#1518, so I expect minimal actual load from this change. Fixes haskell#1517.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses the issue whereby tarball downloads served by a content delivery network were not counted in statistics.
The patch implements a redirect scheme, where requests to the main host now return a HTTP302 redirect response, with a Cache-Control: No-Store header, and counts the download. Then, the request is redirected to the user-content host for the download, which can be served either by Hackage itself or by some other cache.
This will result in more traffic to Hackage due to the cache policy on the redirection. The download count feature has been optimized in #1518, so I expect minimal actual load from this change.
Fixes #1517.