Repository navigation
Fix double-escaping of parameter bodies for DeepQuery - #1930
Merged
ysangkok merged 3 commits intoNov 11, 2026
Merged
Conversation
leo-artificial
marked this pull request as ready for review
November 5, 2026 15:12
LaurentRDC
reviewed
Nov 5, 2026
Comment on lines
-207
to
-208
| let exampleQuery = BookQuery{author = "Herbert", year = 1965} | ||
| apiLink bFilter exampleQuery `shouldBeLinkUnescaped` "books?filter[author]=Herbert&filter[year]=1965" |
Contributor
There was a problem hiding this comment.
Would it be possible to add a test example using a date, like you had in the issue #1929 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the fix described in #1929.