Skip to content

Also check if the total hash count of a hashlist needs to be fixed#2033

Merged
s3inlc merged 1 commit intodevfrom
global-chunk-scan-improvement
Apr 13, 2026
Merged

Also check if the total hash count of a hashlist needs to be fixed#2033
s3inlc merged 1 commit intodevfrom
global-chunk-scan-improvement

Conversation

@s3inlc
Copy link
Copy Markdown
Member

@s3inlc s3inlc commented Apr 10, 2026

So far only the cracked hashes counts where check, but not the total hash counts of the hashlist.

@s3inlc s3inlc requested a review from jessevz April 10, 2026 12:51
@jessevz
Copy link
Copy Markdown
Contributor

jessevz commented Apr 11, 2026

We could reduce the amount of database queries here by instead of doing Factory::getHashlistFactory()->set(....) when a count doesnt match, is by adding the field that needs to be updated to an array, and then afterwards do mset if the array is not empty, then both hashcount and cracked can be updated in a single query. But this is a very minor performance improvement so I approved this pr

@s3inlc
Copy link
Copy Markdown
Member Author

s3inlc commented Apr 13, 2026

This action is one of the candidates we will have to consider for background tasks anyway when we are going to add something like this. I would consider in such a refactoring then to optimize the implementation.

@s3inlc s3inlc merged commit 411bb62 into dev Apr 13, 2026
4 checks passed
@s3inlc s3inlc deleted the global-chunk-scan-improvement branch April 13, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants