Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| const chromeOnIosUserAgent = | ||
| "Mozilla/5.0 (iPhone; CPU iPhone OS 17_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/128.0.0.0 Mobile/15E148 Safari/604.1"; |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
A hardcoded username in plain text is identified. Store it properly in an environment variable.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by node_username.
You can view more details about this finding in the Semgrep AppSec Platform.
| const firefoxUserAgent = | ||
| "Mozilla/5.0 (Macintosh; Intel Mac OS X 14.6; rv:130.0) Gecko/20100101 Firefox/130.0"; |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
A hardcoded username in plain text is identified. Store it properly in an environment variable.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by node_username.
You can view more details about this finding in the Semgrep AppSec Platform.
| const safariUserAgent = | ||
| "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0 Safari/605.1.15"; |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
A hardcoded username in plain text is identified. Store it properly in an environment variable.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by node_username.
You can view more details about this finding in the Semgrep AppSec Platform.
| const chromeUserAgent = | ||
| "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36"; |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
A hardcoded username in plain text is identified. Store it properly in an environment variable.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by node_username.
You can view more details about this finding in the Semgrep AppSec Platform.
27c109c to
3ca3c90
Compare
| const chromeUserAgent = | ||
| "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36"; |
| const safariUserAgent = | ||
| "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0 Safari/605.1.15"; |
| const firefoxUserAgent = | ||
| "Mozilla/5.0 (Macintosh; Intel Mac OS X 14.6; rv:130.0) Gecko/20100101 Firefox/130.0"; |
| const chromeOnIosUserAgent = | ||
| "Mozilla/5.0 (iPhone; CPU iPhone OS 17_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/128.0.0.0 Mobile/15E148 Safari/604.1"; |
a137724 to
a2ae04a
Compare
3ca3c90 to
7c133d9
Compare
3a9b38d to
a588778
Compare
005144e to
2fcab7d
Compare
2fcab7d to
5f61b5c
Compare
a588778 to
57f157b
Compare
5f61b5c to
d105f41
Compare
57f157b to
7ffaf7e
Compare
7ffaf7e to
bc64cc1
Compare
d105f41 to
dfffea9
Compare
Important
Experimental
Adds the Bottom toolbar layout setting. Glass finish by browser ships for everyone.
Summary
Before this PR, the bottom toolbar drew its glass through an SVG backdrop filter that only Chromium renders, so Safari and Firefox showed a flat panel. The bar had one layout, two glass segments, while the design file carries a single-segment version with an Edit / Simulate switch at its end.
Every segment now paints a blurred backdrop first and, on Chromium, fades the refraction in over 0.4s. A Bottom toolbar setting picks between three layouts: the split bar, the design file's mode-switch bar, and a single bar holding every control. All three share the frame that keeps the bar clear of the panels and collapses controls when room runs short.
Links
Changes
Glass finish
GlassSurfacewith a blur layer under its filluserAgentData.brands, with the user agent string as fallbackLayouts
BottomBarbecomes the frame: lane, placement against the panels, collapse context and layout dispatchMotion
Known issues
Next steps
Test coverage
Extraction onto main preserved the complete feature patch without conflicts. All 37 focused glass, Settings keyboard, and preference tests passed. The earlier integrated stack passed package builds, unit tests, types, lint, and architecture checks. Browser recordings and manual checks listed below predate extraction.
glass-finish.test.ts:@hashintel/petrinautunit suite.How to test