FE-1662: add filter to supply chain - #9684
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
PR SummaryMedium Risk Overview Layout changes: site tabs move into each table’s pinned header next to filter and Design system: small Reviewed by Cursor Bugbot for commit 740e15f. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b12a024. Configure here.
| stepFilters, | ||
| stepFilterContext, | ||
| ), | ||
| [generatedOpportunities, searchMatchers, stepFilters, stepFilterContext], |
There was a problem hiding this comment.
Search can disable active filters
Medium Severity
Search is applied before applyStepFilters, and applicability is decided from that already-narrowed list. A committed filter that still belongs on the table can be skipped once search leaves only rows without that property, so those rows reappear and the chip is marked as not applying to the table.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b12a024. Configure here.
| <p className={subtitle}> | ||
| {visibleCount} visible of {opportunities.length} generated from | ||
| dwell cost and planning variance. | ||
| </p> |
There was a problem hiding this comment.
Opportunity counts no longer differ
Low Severity
The opportunities subtitle still compares visibleCount with opportunities.length as if the latter were the unfiltered generated total. Filtering now happens upstream, so both numbers are the already-filtered set and the copy always reads as N visible of N generated.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b12a024. Configure here.


🌟 What is the purpose of this PR?
Updates the supply chain pages in hash-frontend with the new filter bars, and updates the filter bar + sort menu with various QOL improvements to work better.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: