fix: use proper field names in cacheable codecs#845
Merged
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
Integration Test Report 428 files + 2 428 suites +2 18m 39s ⏱️ - 2m 50s Results for commit 7265da3. ± Comparison against base commit f2a1e09. This pull request removes 2 and adds 20 tests. Note that renamed tests count towards both. |
imalygin
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a small bug in the
pbj.cacheableimplementation where embedded hashCode() and equals() bodies used incorrect field names to refer to local temp_ variables. They used camelCase names while the temp_ fields use original protobuf names, which may be snake_case.Test models are updated to verify this fix.
Related issue(s):
Fixes #844
Notes for reviewer:
All tests should pass.
Checklist