fix: [FIND-115] createConfiguration Prematurely Finalizes In-Progress Batch Configuration

[jaime-iobermudez]

This pull request introduces a stricter validation for configuration batch management in the DiamondCutManager, preventing accidental merging or finalization of incomplete batches. The key change is that calling createConfiguration on a configuration ID with an ongoing (incomplete) batch will now revert with a custom error, enforcing explicit batch management and avoiding silent merges.

Batch management and error handling improvements:

• Added a new custom error OngoingBatchConfigurationNotPermitted to both IDiamondCutManager interface files, which is thrown when createConfiguration is called for a configuration ID that already has an in-progress batch. This prevents premature finalization and unintended facet absorption. [1] [2]
• Updated the internal logic in DiamondCutManagerWrapper to revert with the new error if createConfiguration is called on an ongoing batch, instead of silently continuing or merging facets into the existing batch.

Test updates:

• Modified the integration tests for DiamondCutManager to expect the new error when attempting to create a configuration on an ongoing batch, replacing previous tests that allowed silent merges. This ensures the new validation logic is enforced and tested. [1] [2]

Type of change

• Bug fix 🐞
• New feature ✨
• Breaking change 💥
• Documentation update 📖
• Refactor 🔧

Testing

Node version:

• 20
• 22
• 24

Checklist

• Style Guidelines followed ✅
• Documentation Updated 📚
• Linters - No New Warnings ⚠️
• Local Tests Pass ✅
• Effective Tests Added ✔️
• No reduction of Coverage ✅

[themariofrancia]

LGTM