fix: [FIND-033] Force-cancel capability for all corporate action types.#1168
Merged
Conversation
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
marcosio
requested changes
May 21, 2026
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
marcosio
approved these changes
May 21, 2026
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
AlbertoMolinaIoBuilders
approved these changes
May 27, 2026
marcosio
requested changes
May 27, 2026
Contributor
marcosio
left a comment
There was a problem hiding this comment.
Is possible to reuse the new code in the older?
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
marcosio
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new force-cancel capability for all corporate action types, allowing privileged admins to forcibly cancel actions such as coupons, dividends, votings, balance adjustments, and amortizations, regardless of their execution or record date. This is accomplished by adding a new admin role and corresponding methods and events for each action type, ensuring stuck or already-executed actions can be unblocked in a controlled way. Each force-cancel method retains the same access and state guards as the regular cancel methods, except for the date guard, and emits a dedicated event upon successful cancellation.
Force-cancel capability for corporate actions
CORPORATE_ACTION_CANCEL_ADMIN_ROLEconstant toroles.sol, granting privileged admin rights for force-cancelling corporate actions.forceCancelCoupon,forceCancelDividend,forceCancelVoting,forceCancelBalanceAdjustment, andforceCancelAmortizationin their respective storage wrappers and facet contracts. These methods bypass execution/record date checks but retain other access and state guards. [1] [2] [3] [4] [5] [6] [7] [8]Event and documentation enhancements
CouponForceCancelled,DividendForceCancelled,VotingForceCancelled,ScheduledBalanceAdjustmentForceCancelled, andAmortizationForceCancelled. [1] [2] [3] [4]Role and import updates
These changes provide a robust administrative mechanism to resolve stuck or problematic corporate actions while maintaining strict access control and auditability.
Type of change
Testing
Node version:
Checklist