Skip to content

feat(har): support .conda packages in conda push via zstd - #351

Open
BlueLabelscotch wants to merge 1 commit into
mainfrom
worktree-fix-har-conda-zstd
Open

BlueLabelscotch wants to merge 1 commit into
mainfrom
worktree-fix-har-conda-zstd

Conversation

@BlueLabelscotch

Copy link
Copy Markdown
Collaborator

Fixes #336

Problem

push conda rejected .conda files because zstd decompression was not available.

Change

  • Read index.json from the info-*.tar.zst entry of a .conda archive (a zip) using the stdlib archive/zip and klauspost/compress/zstd, matching hc.
  • Share the tar scan between .tar.bz2 and .conda through a new condaMetaFromTar.
  • Keep the existing subdir/name/version checks and the unchanged upload path.
  • klauspost/compress was already an indirect dependency of modules/har; it is now a direct one, with no new modules.
  • Add a table test for the .conda reader: valid archive, missing info-*.tar.zst, info tar without index.json, and a non-zip file.

Module-only change (modules/har).

Testing

go test ./pkg/har/ -run Conda in modules/har

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Code Review Agent🐛

Review completed with 0 suggestions.

Reviewed commit: ed0591c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HAR: Conda .conda package format rejected (no zstd support)

1 participant