Improve Agent browser recovery and finding severity calibration#958
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe system prompt adds severity-calibration rules for findings and recovery instructions for browser failures. Tests verify finding-quality guidance in cloud and local agent prompts, and browser recovery guidance only in cloud agent prompts. ChangesPrompt contracts
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The cloud browser prompt covered the normal interaction workflow but did not distinguish infrastructure recovery from command or element-reference errors. The finding-quality contract also needed an explicit calibration rule so ratings track the impact actually proven without discounting complete severe attack chains.
Scope
Prompt and contract-test changes only. The cloud image and structured finding/report behavior are unchanged.
Validation
corepack pnpm test -- lib/__tests__/system-prompt.test.ts --runInBand(20 tests)corepack pnpm typecheckcorepack pnpm lint(passes with five existing warnings)corepack pnpm exec prettier --check lib/system-prompt.ts lib/__tests__/system-prompt.test.tsManual verification
Summary by CodeRabbit
New Features
Bug Fixes