Add printer market #116

bbarni2020 · 2026-01-17T23:42:15Z

No description provided.

Introduces database schema and migration for printers and printer orders, including new enums and relations. Adds admin and public UI for managing printers and upgrades in the dashboard, with create, update, and delete functionality. Updates Svelte components and database schema to support the new printer market feature.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/routes/dashboard/market/printer/[id]/+page.server.ts

src/routes/dashboard/market/printer/+page.server.ts

Copilot · 2026-01-18T18:32:18Z

src/routes/dashboard/admin/admin/orders/+page.server.ts

+		for (const item of selectedItems) {
+			if (item.startsWith('marketItem-')) {
+				const id = parseInt(item.slice('marketItem-'.length));
+				if (!id) throw error(400, { message: 'malformed market item filter' });
+				marketItemFilter.push(id);
+			} else if (item.startsWith('printer-')) {
+				const id = parseInt(item.slice('printer-'.length));
+				if (!id) throw error(400, { message: 'malformed printer filter' });
+				printerFilter.push(id);


The validation check 'parseInt(id) || null' at line 68 and 72 will incorrectly treat a valid ID of 0 as invalid because 0 is falsy in JavaScript. While printer IDs likely start at 1, this is still a potential bug. The validation should use 'isNaN(id)' or 'id === 0' explicitly if 0 is an invalid ID, rather than relying on truthiness checks.

Copilot · 2026-01-18T18:32:18Z

src/routes/dashboard/admin/admin/market/printer/+page.server.ts

+		const name = formData.get('name')?.toString();
+		const description = formData.get('description')?.toString();
+		const image = formData.get('image')?.toString();
+		const isBase = formData.get('isBase') === 'on';


The 'isBase' field is being checked via 'formData.get('isBase') === 'on'', but 'isBase' is not a form field name that's actually submitted from the admin form. The form uses a checkbox with id 'isBase' that changes the local 'formType' state, but there's no hidden input or form field named 'isBase' being submitted. This will cause the server to always treat submissions as upgrades (isBase will always be false), leading to incorrect data being saved.

Suggested change

const isBase = formData.get('isBase') === 'on';

const formType = formData.get('formType')?.toString() || 'base';

const isBase = formType === 'base';

Copilot · 2026-01-18T18:32:19Z

src/routes/dashboard/admin/admin/market/printer/+page.svelte

+					class="h-4 w-4"
+				/>
+				<label for="isBase" class="font-semibold cursor-pointer">Base Printer</label>
+			</div>


The admin form is missing a hidden input or proper form field to submit whether the printer is a base printer or upgrade. The checkbox at line 157-167 changes local state (formType) but doesn't have a 'name' attribute, so the server won't receive this information. This causes the server-side logic at line 29 and 70 of +page.server.ts to always evaluate 'isBase' as false. Add a hidden input field that tracks the formType value, or add a 'name' attribute to the checkbox.

Suggested change

</div>

</div>

<input type="hidden" name="isBase" value={formType === 'base' ? 'true' : 'false'} />

Copilot · 2026-01-18T18:32:19Z

src/routes/dashboard/admin/admin/market/printer/+page.svelte

+                    <label class="block">
+						<span class="mb-1 block font-semibold">Min Shop Score</span>
+						<input
+							type="number"
+							name="minShopScore"
+							bind:value={form.minShopScore}
+							min="0"
+							class="w-full rounded-lg border border-primary-700 bg-primary-900 p-2 text-primary-100"
+						/>
+					</label>
+					<label class="block">
+						<span class="mb-1 block font-semibold">Max Shop Score</span>
+						<input
+							type="number"
+							name="maxShopScore"
+							bind:value={form.maxShopScore}
+							min="0"
+							class="w-full rounded-lg border border-primary-700 bg-primary-900 p-2 text-primary-100"
+						/>
+					</label>
+                    <label class="block">


There's inconsistent indentation with mixed tabs and spaces. Line 184 and 204 use spaces for indentation while the rest of the file uses tabs. This should be corrected to maintain consistent code formatting throughout the file.

Copilot · 2026-01-18T18:32:19Z

src/routes/dashboard/market/printer/[id]/+page.server.ts

+		if (locals.user.idvToken) {
+			let userData = null;
+
+			try {
+				const token = decrypt(locals.user.idvToken);
+				userData = await getUserData(token);
+			} catch {
+				userDataError = true;
+			}
+
+			addresses = userData?.addresses;
+		} else {
+			userDataError = true;
+		}
+
+		return {
+			printerData: {
+				...basePrinter,
+				clayPrice: basePrinter.clayPrice || 40
+			},
+			isBase: true,
+			addresses,
+			userDataError
+		};
+	} else {
+		const [upgrade] = await db
+			.select()
+			.from(printer)
+			.where(
+				and(
+					eq(printer.deleted, false),
+					eq(printer.isPublic, true),
+					eq(printer.id, id),
+					isNotNull(printer.requiresId)
+				)
+			)
+			.limit(1);
+
+		if (!upgrade) {
+			throw error(404, { message: 'printer upgrade not found' });
+		}
+
+		const computedPrice = calculateMarketPrice(
+			upgrade.minPrice,
+			upgrade.maxPrice,
+			upgrade.minShopScore,
+			upgrade.maxShopScore,
+			locals.user.shopScore
+		);
+
+		const discountAmount = (upgrade.maxPrice - computedPrice) / upgrade.maxPrice;
+
+		let userDataError = false;
+		let addresses = null;
+
+		if (locals.user.idvToken) {
+			let userData = null;
+
+			try {
+				const token = decrypt(locals.user.idvToken);
+				userData = await getUserData(token);
+			} catch {
+				userDataError = true;
+			}
+
+			addresses = userData?.addresses;
+		} else {
+			userDataError = true;
+		}


There's duplicated code for fetching user address data. Lines 36-49 and lines 91-104 contain identical logic for fetching addresses via idvToken. This code should be extracted into a helper function to improve maintainability and reduce duplication.

Copilot · 2026-01-18T18:32:19Z

src/routes/dashboard/market/printer/[id]/+page.server.ts

+
+export async function load({ locals, params, url }) {
+	if (!locals.user) {
+		throw error(500);


The function throws a 500 error when the user is not authenticated (line 12). A 500 status code indicates an internal server error, but an unauthenticated user is not a server error - it's a client error. This should return a 401 (Unauthorized) or 403 (Forbidden) status code instead, or redirect to a login page.

Suggested change

throw error(500);

throw error(401, { message: 'unauthenticated' });

ArcaEge

Sending more detailed info in the slack channel

ArcaEge · 2026-01-18T19:51:45Z

Merge the stuff I pushed to the printer-shop branch on this repo into your own fork (I can't commit to your fork sorry), then have a look at what I sent in Slack

Fix some of the issues with the pr

bbarni2020 · 2026-01-18T20:30:57Z

Merged

Copilot AI review requested due to automatic review settings January 17, 2026 23:42

Copilot started reviewing on behalf of bbarni2020 January 17, 2026 23:42 View session

This comment was marked as outdated.

Sign in to view

Add preferredBasePrinterId to user schema and UI fixes

d47cb16

bbarni2020 requested a review from Copilot January 18, 2026 00:06

Copilot started reviewing on behalf of bbarni2020 January 18, 2026 00:06 View session

This comment was marked as outdated.

Sign in to view

bbarni2020 and others added 2 commits January 18, 2026 01:21

Update src/routes/dashboard/market/printer/[id]/+page.server.ts

56a322d

Co-authored-by: Copilot <[email protected]>

Fix printer filter logic and currency handling in printer market

544d083

ArcaEge requested a review from Copilot January 18, 2026 18:28

Copilot started reviewing on behalf of ArcaEge January 18, 2026 18:28 View session

Copilot AI reviewed Jan 18, 2026

View reviewed changes

ArcaEge requested changes Jan 18, 2026

View reviewed changes

Fix some of the issues with the pr

054cad6

Merge pull request #5 from hackclub/printer-shop

b2e7dbd

Fix some of the issues with the pr

Add printer checkout flow and admin support for printer orders

c287d77

bbarni2020 closed this Jan 18, 2026

	const isBase = formData.get('isBase') === 'on';
	const formType = formData.get('formType')?.toString() \|\| 'base';
	const isBase = formType === 'base';

	</div>
	</div>
	<input type="hidden" name="isBase" value={formType === 'base' ? 'true' : 'false'} />

	throw error(500);
	throw error(401, { message: 'unauthenticated' });

Add printer market #116

Add printer market #116

Uh oh!

Conversation

bbarni2020 commented Jan 17, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

ArcaEge left a comment

Choose a reason for hiding this comment

Uh oh!

ArcaEge commented Jan 18, 2026

Uh oh!

bbarni2020 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants