fix: add pageTitle to focus browser window, no need for browser name#32
Merged
cmorten merged 1 commit intoguidepup:mainfrom Apr 6, 2026
Merged
fix: add pageTitle to focus browser window, no need for browser name#32cmorten merged 1 commit intoguidepup:mainfrom
cmorten merged 1 commit intoguidepup:mainfrom
Conversation
1 task
cmorten
force-pushed
the
fix-chromium-rename
branch
from
ebeba86 to
f35cf37
Compare
cmorten
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
@cmorten There was no issue, I created the PR directly ^.^
Details
In playwright v1.57.0 they used another name for chromium, which breaks the current
navigateToWebContentimplementation.I add
page.getTitle()to fetch the correct browser window and kept the old implementation for older playwright versions.CheckList