test: cover isCompositeType identity across package entrypoints#4831
Open
dosacha wants to merge 1 commit into
Open
test: cover isCompositeType identity across package entrypoints#4831dosacha wants to merge 1 commit into
dosacha wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
|
2cf9bec to
18d5a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds integration coverage for
isCompositeTypeidentity across GraphQL.js package entrypoints and module conditions.This is related to #4830, where upstream code using:
can observe no composite types if GraphQL type instances and predicates come from different evaluated
graphqlmodule instances.What changed
graphqlandgraphql/typeshare the sameGraphQLObjectTypegraphqlandgraphql/typeshare the sameGraphQLStringgraphqlandgraphql/typeshare the sameisCompositeTypeisCompositeTypeisCompositeTypepredicatesrequire('graphql/type')path checks alongside the existingrequire('graphql')path check.Why
GraphQL.js v17 type predicates rely on internal
__kindbrand symbols. If supported package entrypoints or module conditions accidentally evaluate separate GraphQL.js module instances, a type created by one entrypoint can fail a predicate imported from another entrypoint.This test does not change duplicate-module semantics. It only ensures that the supported package entrypoints and CJS/ESM conditions preserve predicate identity for the same built package.
Tests
Ran:
Also ran a smoke check against the built npm package:
Not run:
because it requires the full Docker-based integration test environment.
Refs #4830